Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Fix infrastructure deployment and assertions in end-to-end tests. #1816

Merged
merged 5 commits into from
Apr 7, 2025
Merged

ci: Fix infrastructure deployment and assertions in end-to-end tests. #1816

merged 5 commits into from
Apr 7, 2025

Conversation

phipag
Copy link
Contributor

@phipag phipag commented Apr 2, 2025

Issue #, if available: #1815

Description of changes:

This PR restores the functionality of the existing end-to-end tests.

  • Fixes infrastructure deployment by disabling bootstrap version checks in CFN template synthesized from CDK
  • Fixes assertions in several end-to-end test files which were outdated
  • Updated dependencies to newest versions
  • Smaller fixes (e.g. some SonarLint issues)

Checklist

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@phipag phipag added bug Something isn't working maintenance governance labels Apr 2, 2025
@phipag phipag self-assigned this Apr 2, 2025
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Apr 2, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@phipag phipag linked an issue Apr 2, 2025 that may be closed by this pull request
Maintenance: Restore functionality of existing end-to-end tests #1815
Closed
2 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 2, 2025

💾 Artifacts Size Report

Module Version Size (KB)
powertools-common 2.0.0-SNAPSHOT 13.75
powertools-serialization 2.0.0-SNAPSHOT 22.88
powertools-logging 2.0.0-SNAPSHOT 38.88
powertools-logging-log4j 2.0.0-SNAPSHOT 28.06
powertools-logging-logback 2.0.0-SNAPSHOT 21.86
powertools-tracing 2.0.0-SNAPSHOT 19.10
powertools-metrics 2.0.0-SNAPSHOT 18.49
powertools-parameters 2.0.0-SNAPSHOT 17.41
powertools-validation 2.0.0-SNAPSHOT 19.79
powertools-cloudformation 2.0.0-SNAPSHOT 16.76
powertools-idempotency-core 2.0.0-SNAPSHOT 35.18
powertools-idempotency-dynamodb 2.0.0-SNAPSHOT 12.40
powertools-large-messages 2.0.0-SNAPSHOT 17.41
powertools-batch 2.0.0-SNAPSHOT 21.42
powertools-parameters-ssm 2.0.0-SNAPSHOT 10.65
powertools-parameters-secrets 2.0.0-SNAPSHOT 9.86
powertools-parameters-dynamodb 2.0.0-SNAPSHOT 11.90
powertools-parameters-appconfig 2.0.0-SNAPSHOT 11.40

@phipag phipag mentioned this pull request Apr 2, 2025
Open
2 tasks
@phipag
Copy link
Contributor Author

phipag commented Apr 2, 2025

Tested pass when running in my personal AWS account from my local computer.

[INFO] Results:
[INFO] 
[INFO] Tests run: 17, Failures: 0, Errors: 0, Skipped: 0
[INFO] 
[INFO] 
[INFO] --- checkstyle:3.3.0:check (default) @ powertools-e2e-tests ---
[INFO] Starting audit...
Audit done.
[INFO] You have 0 Checkstyle violations.
[INFO] 
[INFO] --- failsafe:3.1.2:verify (default) @ powertools-e2e-tests ---
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  18:23 min
[INFO] Finished at: 2025-04-02T14:20:56+02:00
[INFO] ------------------------------------------------------------------------

@phipag phipag mentioned this pull request Apr 2, 2025
Closed
2 tasks
@dreamorosi dreamorosi self-requested a review April 4, 2025 09:11
dreamorosi
dreamorosi reviewed Apr 4, 2025
View reviewed changes
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

A couple notes:

  • could you explain what this means in practice? "Fixes infrastructure deployment by disabling bootstrap version checks in CFN template synthesized from CDK"
  • for other Powertools for AWS versions we usually consider bugs (and thus use fix) when something is related to runtime behavior in AWS Lambda. This also helps inform the semver during releases.

@phipag
Copy link
Contributor Author

phipag commented Apr 4, 2025 •
edited
Loading

Thanks for your comment @dreamorosi.

@phipag phipag changed the title fix(ci): Fix infrastructure deployment and assertions in end-to-end tests. ci: Fix infrastructure deployment and assertions in end-to-end tests. Apr 6, 2025
@dreamorosi dreamorosi self-requested a review April 7, 2025 08:45
dreamorosi
dreamorosi approved these changes Apr 7, 2025
View reviewed changes
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying and updating the PR title.

Hopefully we can also fix/remove the failing checks in PRs in the future.

@phipag phipag merged commit 7f604e4 into v2 Apr 7, 2025
10 of 13 checks passed
@phipag phipag deleted the phipag/fix-e2e-tests branch April 7, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamorosi dreamorosi dreamorosi approved these changes

Assignees

@phipag phipag

Labels
bug Something isn't working governance maintenance size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Maintenance: Restore functionality of existing end-to-end tests
2 participants
@phipag @dreamorosi